Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PRF Extension #390

Merged
merged 5 commits into from Jul 28, 2023
Merged

Support for PRF Extension #390

merged 5 commits into from Jul 28, 2023

Conversation

kspearrin
Copy link
Contributor

This PR adds support for the PRF extension to the extension client input/output models.

All existing tests pass, but I am not sure if/what new tests need to be added for PRF support in this library.

@kspearrin
Copy link
Contributor Author

@dotnet-policy-service agree company="Bitwarden"

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #390 (a400af8) into master (5e72564) will decrease coverage by 0.05%.
The diff coverage is 62.50%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   76.80%   76.76%   -0.05%     
==========================================
  Files          89       92       +3     
  Lines        2531     2539       +8     
  Branches      427      427              
==========================================
+ Hits         1944     1949       +5     
- Misses        466      469       +3     
  Partials      121      121              
Impacted Files Coverage Δ
...ls/Objects/AuthenticationExtensionsClientInputs.cs 16.66% <0.00%> (-3.34%) ⬇️
...odels/Objects/AuthenticationExtensionsPRFInputs.cs 0.00% <0.00%> (ø)
...s/Objects/AuthenticationExtensionsClientOutputs.cs 100.00% <100.00%> (ø)
...dels/Objects/AuthenticationExtensionsPRFOutputs.cs 100.00% <100.00%> (ø)
...odels/Objects/AuthenticationExtensionsPRFValues.cs 100.00% <100.00%> (ø)

@kspearrin
Copy link
Contributor Author

Added a bit of testing to match what I see being done with other extension properties.

@abergs abergs merged commit dc8916b into passwordless-lib:master Jul 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants