Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix demo project starting exception: change TargetFrameworks to TargetFramework #403

Merged
merged 1 commit into from Jul 28, 2023

Conversation

yedidyas
Copy link
Contributor

Before my suggested change, on performing dotnet run you get a framework version specification error.

image

This change makes the demo project a "clone&run" project, with zero extra effort.

The change is based on this response:
AvaloniaUI/avalonia-dotnet-templates#25 (comment)

When performing `dotnet run` this change prevents a framework version specification error
@codecov-commenter
Copy link

Codecov Report

Merging #403 (20bc123) into master (53caf81) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #403   +/-   ##
=======================================
  Coverage   74.61%   74.61%           
=======================================
  Files          92       92           
  Lines        2714     2714           
  Branches      453      453           
=======================================
  Hits         2025     2025           
  Misses        575      575           
  Partials      114      114           

@yedidyas
Copy link
Contributor Author

@dotnet-policy-service agree [company="{OwnID}"]

@yedidyas
Copy link
Contributor Author

@dotnet-policy-service agree company="OwnID"

@yedidyas
Copy link
Contributor Author

yedidyas commented Jul 1, 2023

@abergs I'd appreciate your review here and on this one
#404

@yedidyas yedidyas marked this pull request as draft July 22, 2023 19:37
@yedidyas yedidyas marked this pull request as ready for review July 22, 2023 19:37
@abergs abergs merged commit 1e7967b into passwordless-lib:master Jul 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants