Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Code Quality #405

Merged
merged 10 commits into from Jul 28, 2023
Merged

Improve Code Quality #405

merged 10 commits into from Jul 28, 2023

Conversation

iamcarbon
Copy link
Sponsor Contributor

@iamcarbon iamcarbon commented Jul 4, 2023

  • Make RgbPaletteEntry a readonly struct
  • Makes UafVersion a readonly struct
  • Makes AuthenticationDevicePublicKeyOutputs immutable
  • Makes PublicKeyCredentialDescriptor immutable
  • Fixes a misspelled class name

@iamcarbon
Copy link
Sponsor Contributor Author

@abergs @aseigler Ready for feedback / review.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #405 (d22e731) into master (53caf81) will increase coverage by 0.26%.
The diff coverage is 60.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   74.61%   74.88%   +0.26%     
==========================================
  Files          92       92              
  Lines        2714     2731      +17     
  Branches      453      456       +3     
==========================================
+ Hits         2025     2045      +20     
+ Misses        575      573       -2     
+ Partials      114      113       -1     
Impacted Files Coverage Δ
Src/Fido2/AuthenticatorAssertionResponse.cs 43.04% <ø> (ø)
...ido2/Objects/DevicePublicKeyAuthenticatorOutput.cs 41.37% <ø> (ø)
Src/Fido2.Models/Metadata/UafVersion.cs 45.45% <45.45%> (-54.55%) ⬇️
Src/Fido2.Models/Metadata/RgbPaletteEntry.cs 50.00% <50.00%> (-50.00%) ⬇️
...desiredMetadataStatusFido2VerificationException.cs 60.00% <50.00%> (ø)
Src/Fido2/AuthenticatorAttestationResponse.cs 76.00% <50.00%> (ø)
...o2.Models/Objects/PublicKeyCredentialDescriptor.cs 80.00% <77.77%> (+17.50%) ⬆️
.../AuthenticationExtensionsDevicePublicKeyOutputs.cs 83.33% <83.33%> (-16.67%) ⬇️
Src/Fido2/Objects/AttestedCredentialData.cs 85.10% <100.00%> (+2.96%) ⬆️

... and 1 file with indirect coverage changes

@iamcarbon
Copy link
Sponsor Contributor Author

@abergs Ping. Let me know if you have any feedback.

@abergs
Copy link
Collaborator

abergs commented Jul 21, 2023

@iamcarbon Will merge #379 before this one.

@abergs abergs merged commit 2ef5ff3 into passwordless-lib:master Jul 28, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants