New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Code Quality #405
Merged
Merged
Improve Code Quality #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sponsor
Contributor
iamcarbon
commented
Jul 4, 2023
•
edited
edited
- Make RgbPaletteEntry a readonly struct
- Makes UafVersion a readonly struct
- Makes AuthenticationDevicePublicKeyOutputs immutable
- Makes PublicKeyCredentialDescriptor immutable
- Fixes a misspelled class name
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 74.61% 74.88% +0.26%
==========================================
Files 92 92
Lines 2714 2731 +17
Branches 453 456 +3
==========================================
+ Hits 2025 2045 +20
+ Misses 575 573 -2
+ Partials 114 113 -1
|
@abergs Ping. Let me know if you have any feedback. |
@iamcarbon Will merge #379 before this one. |
abergs
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.