Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing comments on public methods #440

Merged
merged 1 commit into from Nov 6, 2023

Conversation

joegoldman2
Copy link
Contributor

  • Add missing comments to some public methods
  • Fix a few spelling mistakes

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bfc2f5b) 73.83% compared to head (8366d34) 73.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #440   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files          99       99           
  Lines        2710     2710           
  Branches      445      445           
=======================================
  Hits         2001     2001           
  Misses        604      604           
  Partials      105      105           
Files Coverage Δ
Src/Fido2.AspNet/DateTimeUtilities.cs 100.00% <ø> (ø)
...rc/Fido2.AspNet/DistributedCacheMetadataService.cs 88.28% <100.00%> (ø)
...rc/Fido2.Models/Objects/MakeNewCredentialResult.cs 100.00% <ø> (ø)
Src/Fido2/AuthenticatorAssertionResponse.cs 42.65% <ø> (ø)
Src/Fido2/Fido2.cs 90.00% <ø> (ø)
Src/Fido2/Objects/AttestedCredentialData.cs 86.11% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abergs
Copy link
Collaborator

abergs commented Oct 13, 2023

Hey @joegoldman2 - thanks for the PR's. Would you mind sending me an email to anders@andersaberg.com, I just have something I want to check with you.

@aseigler aseigler self-requested a review October 23, 2023 14:23
Copy link
Collaborator

@aseigler aseigler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup!

@abergs abergs merged commit 43442bb into passwordless-lib:master Nov 6, 2023
7 checks passed
@joegoldman2 joegoldman2 deleted the feat/comments branch November 6, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants