List<PublicKeyCredentialDescriptor>/IEnumerable<PublicKeyCredentialDescriptor> to IReadOnlyList<PublicKeyCredentialDescriptor>
#447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
==========================================
+ Coverage 73.88% 73.92% +0.03%
==========================================
Files 99 99
Lines 2711 2711
Branches 445 443 -2
==========================================
+ Hits 2003 2004 +1
Misses 603 603
+ Partials 105 104 -1 ☔ View full report in Codecov by Sentry. |
Regenhardt
reviewed
Oct 18, 2023
|
I would prefer IReadOnlyList to IEnumerable here. |
… IEnumerable<PublicKeyCredentialDescriptor>
joegoldman2
force-pushed
the
fix/191
branch
3 times, most recently
from
f452c6e
to
dfaaed1
Compare
joegoldman2
changed the title
List<PublicKeyCredentialDescriptor> to IEnumerable<PublicKeyCredentialDescriptor>List<PublicKeyCredentialDescriptor>/IEnumerable<PublicKeyCredentialDescriptor> to IReadOnlyList<PublicKeyCredentialDescriptor>
abergs
reviewed
Nov 2, 2023
|
@iamcarbon Do you have any comments regarding the allocations? |
|
Looks good to me! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191.
The proposal in the issue was to change
AllowCredentialstoList<PublicKeyCredentialDescriptor>, I preferred to do the opposite because I think it's better to expose interfaces.There are other parameters that deserve to be changed to
IEnumerableas well, such asstoredDevicePublicKeys:fido2-net-lib/Src/Fido2/IFido2.cs
Line 20 in 15263ca
I could do a PR for the others if this one is approved and merged.