Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timeout data type to ulong #462

Merged
merged 1 commit into from Nov 17, 2023

Conversation

joegoldman2
Copy link
Contributor

Fixes #198.

From the spec, for both PublicKeyCredentialCreationOptions and PublicKeyCredentialRequestOptions:

timeout, of type [unsigned long](https://heycam.github.io/webidl/#idl-unsigned-long)

So I changed the data type to ulong.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebfd75d) 73.83% compared to head (7d7e118) 73.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   73.83%   73.83%           
=======================================
  Files          99       99           
  Lines        2710     2710           
  Branches      445      445           
=======================================
  Hits         2001     2001           
  Misses        604      604           
  Partials      105      105           
Files Coverage Δ
Src/Fido2.Models/AssertionOptions.cs 84.21% <100.00%> (ø)
Src/Fido2.Models/CredentialCreateOptions.cs 53.48% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abergs abergs merged commit 77f2da4 into passwordless-lib:master Nov 17, 2023
7 checks passed
@joegoldman2 joegoldman2 deleted the fix/198 branch November 17, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent Timeout data type
3 participants