Work without needing jQuery

[dremonkey]

Curious as to what your thoughts are on making this work without needing jQuery. I have a working fork if you would like to take a look.

https://github.com/dremonkey/angular-masonry/compare/nojquery

[passy]

I like it! That actually looks a lot cleaner. Would you mind opening a pull request for that with just the uncompiled source changed?

[dremonkey]

No problem. Glad you like it. Just opened the pull request - #41

[macneib]

Will this PR be accepted? I would like to use this module without jQuery.

[passy]

@macneib Totally. If you want to pick up the previous work and clean it up, I'm more than happy to merge it.

[nonec]

I've added the changes to your current version and it works for me (didn't work at all before) :)

[macneib]

@nonec it would be awesome if you would be willing to submit those changes.
I'm debating the idea of working on this, but your work would save me a lot of time.
Cheers!

[nonec]

Sure, I'd like to help! But I didn't include all the changes. Only the ones made to "angular-masonry.js" because I downloaded this as standalone. Will it still be of help?

[macneib]

Would you be willing to fork this repo, insert your changes to angular-masonry and apply your changes with a PR? I would be more than happy to do that for you but you'll need to put the files up somewhere.

[macneib]

Ok, I've spent some time looking over the fork by @dremonkey, and it seems solid.
The primary barrier with any PR rests on the actions on a brave soul who is wililng to adapt the test scripts.
I don't have the knowedge required to port the jquery elements at this time, however I'll tinker away at it.
Until then I'll be using the forked version.
Learning jquery so I can gid rid of it. sigh...

[nonec]

Yeah it is. I didn't have to change much. It just didn't work out of the box. I have set up the fork, but it's really just a hack of the changes made by @dremonkey put into the current codebase. So I'm not sure if a PR will be useful for this. If you want to work an that to prepare the PR let me knew and I can add you to that fork.

[macneib]

@dremonkey's code worked fine for me. Do you have a nojquery branch on your fork?

[nonec]

Nope, just put the changed .js-file in there. But there could be one created...

[macneib]

this part. This is hard for me to understand.

$.fn.masonry = sinon.spy()

[nonec]

I guess it's using the sinon framework for the tests to spy on the masonry:
http://sinonjs.org/

Here is an explanition of the difference between sying and mocking:
http://stackoverflow.com/questions/12827580/mocking-vs-spying-in-mocking-frameworks

[macneib]

@passy just want to check what the house rules are before I get too involved.

I'd like to structure the test like so /src/angular-masonry.spec.js

Since I'm at it, would there be any objection to updating the Gruntfile to use ngAnnotate instead of ngMin which is obsolete atm?

There are some other things but I expect with my schedule being the way it is modifiying everything will take some time.

[TimPetricola]

Any news on this one?

[macneib]

Day job called. Pretty sure I won't have time for a while.

[simonsayscode]

Is there any progress on this? It seems like it's a pretty innocuous change since you don't need to depend on jQuery to utilize Masonry directly.

[passy]

Still happy to take PRs, @simonsayscode. :)