Nojquery

[dremonkey]

Removing jQuery dependency

[passy]

Sorry for the long delay, @dremonkey. Open source stuff is a bit crazy at the moment. :)

Could you have a look at the failing tests?

[dremonkey]

No worries. I understand completely. I will take a look as soon as I have some time... hopefully this weekend.

[passy]

Thanks, @dremonkey!

[jribeiro]

@dremonkey have you had time to look at the failing tests?

[dremonkey]

@jribeiro sorry... got busy. But got around to doing some work on it today. I'm very new to Jasmine so to be honest I'm not sure if what I did is right... but as far as I can tell the first 12 tests are working, one of which is new.

But I am having issues with the last two which I currently have commented out. I will try to get them working this week.

Anyone a little more experienced with writing tests is free to take a look...

[jribeiro]

No worries. I do have experience in writing tests. I'll take a look in a bit

[JonnyBGod]

+1

[debuggingfuture]

+1

[justinhrobbins]

+1

[passy]

@jribeiro ping :)

[jspaper]

+1

[passy]

If any of the +1ers wants to pick this up, please feel free to. :)

[kencaron]

+1, wish I was more comfortable with tests/had more time.

[manikantag]

+1

Pull request is open around 4 months back. Are there any issues other than tests to merge?
But it says, 'All is well — The Travis CI build passed'.

[passy]

It should be just about adding tests for the new functionality, the rest
looked solid.

+1

Pull request is open around 4 months back. Are there any issues other than
tests to merge?
But it says, 'All is well — The Travis CI build passed'.

—
Reply to this email directly or view it on GitHub
#41 (comment).

[pasine]

+1.
Is there any issue with the current pull request?

[passy]

The PR has merge conflicts. Happy to review it again after it's rebased.

[passy]

Closing due to lack of activity. If anyone wants to pick this up, please feel free to open a new PR.