Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmax of response function #201

Closed
mbakker7 opened this issue Jun 8, 2020 · 2 comments
Closed

tmax of response function #201

mbakker7 opened this issue Jun 8, 2020 · 2 comments
Assignees
Labels
enhancement Indicates improvement of existing features
Milestone

Comments

@mbakker7
Copy link
Collaborator

mbakker7 commented Jun 8, 2020

In a previous version of Pastas, the rfunc of a StressModel used to have a tmax. This attribute is removed and there is now a get_tmax function, but that function requires the parameters as input. That is inconvenient. Maybe allow parameters to be None and then return the tmax for the current optimal parameters? Is tmax really not stored anywhere?

@raoulcollenteur
Copy link
Member

raoulcollenteur commented Jul 15, 2020

tmax is not stored somewhere anymore and is calculated using the parameters and cutoff. I'll add a convenience method to the Model class to obtain the tmax:

ml.get_tmax(sm="recharge", cutoff=0.999)

EDIT: get_tmax already exists. I'll add a method ml.get_response_tmax

@raoulcollenteur raoulcollenteur self-assigned this Jul 15, 2020
@raoulcollenteur raoulcollenteur added the enhancement Indicates improvement of existing features label Jul 15, 2020
@raoulcollenteur raoulcollenteur added this to the 0.15.0 milestone Jul 15, 2020
@raoulcollenteur
Copy link
Member

Fixes. Users may now use:

ml.get_response_tmax("recharge", cutoff=0.99)

Also added to the documentation. Closing Issue.

raoulcollenteur added a commit that referenced this issue Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates improvement of existing features
Projects
None yet
Development

No branches or pull requests

2 participants