Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] inform user when WellModel is not using the distance parameter #380

Closed
dbrakenhoff opened this issue Mar 11, 2022 · 1 comment
Closed

[ENHANCEMENT] inform user when WellModel is not using the distance parameter #380

dbrakenhoff opened this issue Mar 11, 2022 · 1 comment
Assignees
@dbrakenhoff
Labels
enhancement Indicates improvement of existing features

Comments

@dbrakenhoff
Copy link
Member

Describe the proposed enhancement
When using certain methods of the model object that require stressmodel parameters, these are taken from the ml.parameters dataframe. For the WellModel this means the distance parameter(s) are not taken into consideration. This should be more explicit to avoid mistakes during interpretation.

Expected behavior
Log message that distance is set to 1.0 m when using these methods.

I think the only necessary change is to add a messages to the HantushWellModel methods step, gain and get_tmax.
@dbrakenhoff dbrakenhoff added the enhancement Indicates improvement of existing features label Mar 11, 2022
dbrakenhoff added a commit that referenced this issue Mar 16, 2022
@dbrakenhoff
fix #380, modification for #177
1a19677 
- add logger info message when HantushWellModel is assuming r=1.0
- print warning when using WellModel if scipy version < 1.8
@dbrakenhoff dbrakenhoff mentioned this issue Mar 16, 2022
Merged
6 tasks
raoulcollenteur added a commit that referenced this issue Mar 29, 2022
@raoulcollenteur
Merge pull request #382 from pastas/wellmodel
28b9435 
fix #380, modification for #177
@dbrakenhoff
Copy link
Member Author

This one can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbrakenhoff dbrakenhoff

Labels
enhancement Indicates improvement of existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbrakenhoff