Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents of Concepts and Source Code may not match for Hantush and HantushWellModel #392

Closed
dbrakenhoff opened this issue May 10, 2022 Discussed in #391 · 1 comment
Closed
Assignees

Comments

@dbrakenhoff
Copy link
Member

Discussed in #391

Originally posted by DataGeoranger May 10, 2022
Hello!

Thanks again for the excellent package and learning materials. I am following through and identify some potential inconsistencies that I wonder if I get a clarification from the author.

First, I read the explanation about Hantush versue HantushWellModel under the pastas.readthedocs.io under chapter 4. There is an comparison of the implementation of parameters of A, a, and b in Hantush method and HantushWellModel. Please see link and screenshot below.
https://pastas.readthedocs.io/en/dev/concepts/hantush_response.ipynb.html
image

However, this doesn't match the explanation of the A, a, and b when I run help(ps.Hantush) and help(ps.HantushWellModel). In particular, the definition of A and b got flipped. Please see screenshot below in comparison to the IO document.

image
image

May I ask which explanation (the code or the io example) correct? Thank you very much!

Best,
Jack

@dbrakenhoff dbrakenhoff self-assigned this May 10, 2022
dbrakenhoff added a commit that referenced this issue May 10, 2022
- improve rfunc docstrings and notebooks for Hantush* response functions
@dbrakenhoff dbrakenhoff mentioned this issue May 10, 2022
6 tasks
dbrakenhoff added a commit that referenced this issue Jun 22, 2022
@dbrakenhoff
Copy link
Member Author

Closed by #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant