Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] validate_stress and validate_oseries should return boolean #536

Closed
raoulcollenteur opened this issue Feb 8, 2023 · 2 comments · Fixed by #616
Closed

[ENHANCEMENT] validate_stress and validate_oseries should return boolean #536

raoulcollenteur opened this issue Feb 8, 2023 · 2 comments · Fixed by #616
Assignees
@raoulcollenteur
Labels
enhancement Indicates improvement of existing features priority 1 normal, deal with in the foreseeable future
Milestone
1.2

Comments

@raoulcollenteur
Copy link
Member

Describe the proposed enhancement

@mbakker7 proposes to have the validate_stress and validate_oseries should return message, to be more specific if it is successful or not.

Expected behavior
A clear and concise description of what you expected to happen.

ml.validate_oseries

Should return True if the series are OK.
False, if there is an error.

Perhaps a logging message would be helpful.

Additional context
@raoulcollenteur raoulcollenteur added the enhancement Indicates improvement of existing features label Feb 8, 2023
@raoulcollenteur raoulcollenteur added this to the 1.1 milestone Feb 8, 2023
@raoulcollenteur raoulcollenteur self-assigned this Feb 8, 2023
@martinvonk martinvonk added the priority 1 normal, deal with in the foreseeable future label Mar 7, 2023
@martinvonk martinvonk changed the title [ENHANCEMENT] validate_stress and validate_oseries should return message [ENHANCEMENT] validate_stress and validate_oseries should return boolean Mar 21, 2023
@martinvonk
Copy link
Collaborator

Maybe we can have a look at pandera for validating our Series / DataFrames. Looks nice. https://pandera.readthedocs.io/en/stable/

Thanks to our friend Arjan: https://www.youtube.com/watch?v=-tU7fuUiq7w

@martinvonk martinvonk modified the milestones: 1.1, 1.2 Aug 3, 2023
@raoulcollenteur raoulcollenteur mentioned this issue Aug 11, 2023
Merged
7 tasks
@raoulcollenteur raoulcollenteur linked a pull request Aug 11, 2023 that will close this issue
Fix issue #536 return true if series are valid, else raise error #616
Merged
7 tasks
raoulcollenteur added a commit that referenced this issue Aug 15, 2023
@raoulcollenteur
Fix issue #536 return true if series are valid, else raise error (#616)
9c7c7ec
@raoulcollenteur
Copy link
Member Author

Fixed as per #616 , closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raoulcollenteur raoulcollenteur

Labels
enhancement Indicates improvement of existing features priority 1 normal, deal with in the foreseeable future
Projects
None yet
Milestone
1.2
2 participants
@raoulcollenteur @martinvonk