Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] fix matplotlib deprecation warnings for TrackSolve #571

Closed
dbrakenhoff opened this issue Mar 21, 2023 · 1 comment · Fixed by #579
Closed

[ENHANCEMENT] fix matplotlib deprecation warnings for TrackSolve #571

dbrakenhoff opened this issue Mar 21, 2023 · 1 comment · Fixed by #579
Assignees
@dbrakenhoff
Labels
development Indicates development of new features priority 1 normal, deal with in the foreseeable future
Milestone
1.1

Comments

@dbrakenhoff
Copy link
Member

Fix matplotlib deprecation warnings showing up in pytest logs.

  • join x-axes has to be done differently (use logic from CompareModels)
  • set_data needs sequence type (make everything an array or array-like)
@dbrakenhoff dbrakenhoff added the development Indicates development of new features label Mar 21, 2023
@dbrakenhoff dbrakenhoff self-assigned this Mar 21, 2023
dbrakenhoff added a commit that referenced this issue Mar 22, 2023
@dbrakenhoff
fix #571: fix mpl deprecation warnings
9dbc689 
- fix axes join
- use sequences in set_data
@dbrakenhoff dbrakenhoff mentioned this issue Mar 22, 2023
Merged
5 tasks
@dbrakenhoff dbrakenhoff linked a pull request Mar 22, 2023 that will close this issue
fix #571 warnings tracksolve #579
Merged
5 tasks
raoulcollenteur pushed a commit that referenced this issue May 3, 2023
@dbrakenhoff
fix #571 warnings tracksolve (#579)
9261a90
@raoulcollenteur raoulcollenteur added this to the 1.1 milestone May 3, 2023
@raoulcollenteur
Copy link
Member

I think this issue can be closed, just merged the PR.

@martinvonk martinvonk added the priority 1 normal, deal with in the foreseeable future label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbrakenhoff dbrakenhoff

Labels
development Indicates development of new features priority 1 normal, deal with in the foreseeable future
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

fix #571 warnings tracksolve pastas/pastas
3 participants
@dbrakenhoff @raoulcollenteur @martinvonk