Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] duplicated columns in ps.plots.compare() if models have the same name #575

Closed
dbrakenhoff opened this issue Mar 22, 2023 · 1 comment · Fixed by #576
Closed

[BUG] duplicated columns in ps.plots.compare() if models have the same name #575

dbrakenhoff opened this issue Mar 22, 2023 · 1 comment · Fixed by #576
Assignees
@dbrakenhoff
Labels
bug Indicates an unintended behavior or coding error
Milestone
1.1

Comments

@dbrakenhoff
Copy link
Member

Columns are duplicated if multiple models have the same name in CompareModels class.

Solution is to check model names for duplicates and append a suffix for the comparison plot.
@dbrakenhoff dbrakenhoff added the bug Indicates an unintended behavior or coding error label Mar 22, 2023
@dbrakenhoff dbrakenhoff self-assigned this Mar 22, 2023
dbrakenhoff added a commit that referenced this issue Mar 22, 2023
@dbrakenhoff
fix #575
89a4336 
- add modelnames attribute and check for duplicates
@dbrakenhoff dbrakenhoff mentioned this issue Mar 22, 2023
Merged
5 tasks
@dbrakenhoff dbrakenhoff linked a pull request Mar 22, 2023 that will close this issue
fix #575 duplicate columns in plots.compare() #576
Merged
5 tasks
raoulcollenteur pushed a commit that referenced this issue May 3, 2023
@dbrakenhoff
fix #575 duplicate columns in plots.compare() (#576)
fa77a86
@raoulcollenteur raoulcollenteur added this to the 1.1 milestone May 3, 2023
@raoulcollenteur
Copy link
Member

Closing after merging #576 . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbrakenhoff dbrakenhoff

Labels
bug Indicates an unintended behavior or coding error
Projects
None yet
Milestone
1.1
2 participants
@dbrakenhoff @raoulcollenteur