Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order of columns of parameters dataframe changes #62

Closed
raoulcollenteur opened this issue Apr 4, 2018 · 3 comments
Closed

Order of columns of parameters dataframe changes #62

raoulcollenteur opened this issue Apr 4, 2018 · 3 comments
Labels
enhancement Indicates improvement of existing features wontfix Indicates that work won't continue on an issue, pull request, or discussion
Milestone
v0.9.6

Comments

@raoulcollenteur
Copy link
Member

The order of the model parameters changes after creation, caused by pandas append method that order alphabetically. As a result, pmin is now shown after pmax, which I find confusing. Should be solved somewhere in the get_init_parameters method.
@raoulcollenteur raoulcollenteur added the enhancement Indicates improvement of existing features label Apr 4, 2018
@raoulcollenteur raoulcollenteur modified the milestones: v0.9.5, v0.9.6 Apr 4, 2018
@raoulcollenteur raoulcollenteur added the wontfix Indicates that work won't continue on an issue, pull request, or discussion label Jul 16, 2018
@raoulcollenteur
Copy link
Member Author

parameters = parameters.append(sm.parameters, sort=False) would fix it, but let's prevent the extra bit of code.

This issue will probably be fixed in Pandas itself in the next major release, so I'll let it be for now.
pandas-dev/pandas#4588

@mbakker7
Copy link
Collaborator

Let's leave this open until it is fixed in pandas.

@mbakker7 mbakker7 reopened this Jul 17, 2018
raoulcollenteur added a commit that referenced this issue Apr 13, 2019
@raoulcollenteur
Tiny change to fix #62
5ea88a7 
Order of parameter columns was defined differently in the init and get_init_parameter methods.
@raoulcollenteur
Copy link
Member Author

Fixed the issue now and as Pandas 0.23 is now default this problem no longer exists. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Indicates improvement of existing features wontfix Indicates that work won't continue on an issue, pull request, or discussion
Projects
None yet
Milestone
v0.9.6
Development

No branches or pull requests
2 participants
@mbakker7 @raoulcollenteur