Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emcee notebook and update parameter bounds #172

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Feb 14, 2020

This PR add an example of how to use MCMC for Pastas models. To enable this, the parameter bounds are changed a little, notably the following:

  • noise_alpha lower bound 0f 1e-5 instead of 0
  • Exponential_A lower bound 0f 1e-5 instead of 0
  • Gamma_A lower bound 0f 1e-5 instead of 0
  • Exponential_a upper bound of 1000 instead of 5000
  • Gamma_a upper bound of 1000 instead of 5000

These should not impact anything, as such a low A/alpha and high Gamma_a are very unlikely to happen.

The notebook is not tested because it depends on the corner and emcee packages.

Copy link
Collaborator

@rubencalje rubencalje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, but cannot oversee the consequences of changing the parameter bounds.

Copy link
Member Author

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- pastas/io/base.py  1
         

Clones removed
==============
+ pastas/rfunc.py  -4
         

See the complete overview on Codacy

Copy link
Member Author

@raoulcollenteur raoulcollenteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to go.

@raoulcollenteur raoulcollenteur merged commit 950cabb into dev Mar 26, 2020
@raoulcollenteur raoulcollenteur deleted the Emcee branch March 26, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants