-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add model comparison plot, deprecation warning Project #181
Conversation
for visually comparing N models
add note to docstring make python3.5 happy be removing f-strings
remove temporary testing code
The failure is being caused by c82df93 which only affects python 3.5 apparently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought. We could also make this method separate, e.g.,
ps.plots.comparison(ml1, ml2)
I don't have a real preference, you?
I'd be fine with it being a separate method. I did it this way because this is how the rest of the plot methods are accessed and thought it might be less easy to find if it was a separate method. Then again, I like the call signature better with The warn method allows it to be of type DeprecationWarning, but I'll change it to the logger.warning. Failure in travis is showing the following message: |
We'll deal with that matplotlib error in the dev-branch. Merging and Closing this PR. |
Added deprecation warning for pastas.Project
Added
ml.plots.compare()
for comparing models on the same figure. The figure is based onml.plots.results()
. See example below.Added a test for this method to test_plot.py