Make default rfunc in StressModelBase None #186 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow rfunc to be none, when no response function is used in the stressmodel - rfunc class is now instantiated in the stress model init, not in stressmodelbase
dbrakenhoff
reviewed
Apr 7, 2020
| @@ -11,7 +11,7 @@ | |||
| obs = pd.read_csv("data/head_nb1.csv", index_col=0, parse_dates=True, | |||
| squeeze=True) | |||
| # add 10 cm to the series from 2007 | |||
There was a problem hiding this comment.
nitpicking here, but should probably change the comment too.
dbrakenhoff
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Checklist before PR can be merged:
ps. cool the new PR request submission format works now!