Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: point to the current dev site #208

Merged
merged 2 commits into from
Jul 6, 2020
Merged

CONTRIBUTING.md: point to the current dev site #208

merged 2 commits into from
Jul 6, 2020

Conversation

dcslagel
Copy link
Contributor

@dcslagel dcslagel commented Jul 3, 2020

Update the url for for the developers section on the documentation site to point to the current location.

The previous link goes to a 'page does not exist' page: (http://pastas.readthedocs.io/en/latest/developers.html)

Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.

Thank you,
DC

Short Description

Add a short description describing the pull request (PR) here.

Checklist before PR can be merged:

  • closes issue #xxxx
  • is documented
  • PEP8 compliant code
  • tests added / passed
  • passes Travis
  • Example Notebook (for new features)

raoulcollenteur and others added 2 commits April 1, 2020 07:37
Upgrade master to v0.14.0
Update the url for for the developers section on the documentation site to point to the current location. 

The previous link goes to a 'page does not exist' page: (http://pastas.readthedocs.io/en/latest/developers.html)

Let me know if this change could be accepted (or rejected) or
needs some additional changes before being approved and merged.

Thank you,
DC
@raoulcollenteur
Copy link
Member

Sorry, my previous response was too fast. The PR would merge into master, but we only allow PR that merge into the Dev-branch. Can you change the PR to merge into Dev? Other than that the PR is welcome!
Cheers,
Raoul

@dcslagel dcslagel changed the base branch from master to dev July 6, 2020 12:30
@dcslagel
Copy link
Contributor Author

dcslagel commented Jul 6, 2020

Hi @raoulcollenteur,

I changed the PR to request merge to the dev branch.

Thanks,
DC

@raoulcollenteur
Copy link
Member

Cool ! Merging the PR. Thanks for your contribution DC!

@raoulcollenteur raoulcollenteur added the enhancement Indicates improvement of existing features label Jul 6, 2020
@raoulcollenteur raoulcollenteur added this to the 0.15.0 milestone Jul 6, 2020
@raoulcollenteur raoulcollenteur merged commit 5e0f2ee into pastas:dev Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants