Dinoloket read method

[tomvansteijn]

Short Description

Added support for reading river level gauges in Dinoloket format. Changes in pastas\read\Dinoloket.py and a simple read test.

Checklist before PR can be merged:

• closes issue reading Dinoloket Peilschalen (level gauges) #204
• is documented
• PEP8 compliant code
• tests added / passed
• passes Travis
• Example Notebook (for new features)

[tomvansteijn]

Ofcourse codacy does not like the duplication in my code. Which is deliberate because I did not want to diverge from the coding style in the original reader class for groundwater levels.

A previous attempt is available in this branch. No duplication, but this contains breaking changes.

[dbrakenhoff]

I think you need to change the filepaths in the notebook to use the forward slash instead of backslash for the tests to pass.

[raoulcollenteur]

@dbrakenhoff can you check the PR? I'll make a new Pastas version the end of this week, would be great if we can add this to the new version!

[dbrakenhoff]

As Tom already mentioned, there's a lot of duplication, but that is unavoidable without changing the original code. I figured the notebook would be a good place to elaborate on all the read methods currently in Pastas, so I made some initial changes so the examples for KNMI, Waterbase can be added later.

p.s. Waterbase was replaced by waterinfo as far as I know. And I don't know if read.waterbase is also capable of reading rws.waterinfo.nl files...? Something to look into.

[dbrakenhoff]

Once travis passes, I will merge.