Improve time_offset #237
Merged
Improve time_offset #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoulcollenteur
added
bug
arguments weere unused after the changes.
raoulcollenteur
approved these changes
Oct 2, 2020
|
Looks good! Gonna merge and close those two issues. |
This was referenced Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #207 and #231
Short Description
This pull request finally solves the problem we have with the time-offset and also problems that arise when changing frequency. There are no new features, just existing ones that should work better. For example, you can now use any supported frequency (e.g. '7D') in example_900, so together with the time_offset of 9 hours. Also when a user now tries to use a model with two stresses that contain different time-offsets (for example daily precipitation at 9:00 and daily evaporation at 1:00, which is common in the netherlands), the user will receive an error explaining the problem, so he can solve it. In the past the model would fail because the simulation did not contain any values (see issue #207).
Checklist before PR can be merged:
ValueError: array of sample points is empty#207 and [BUG] example_900.py errors #231