fix HantushWellModel #313
Merged
fix HantushWellModel #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add option if k0rho -> 0 to return a large number (100 yrs) - this should allow relaxing of parameter bounds for b
6 tasks
|
Just had a thought we could also maybe solve this with |
|
The thought was wrong. So no changes. |
raoulcollenteur
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
HantushWellModel.get_tmax()for when k0rho --> 0.0 to return large response time (100 yrs), instead of np.inf.This should allow wells at large distances to be added without constraining parameter b by those large distances.
Question: Is 100 years a reasonable large number, or too large?
Checklist before PR can be merged:
is documentedinternal changeExample Notebook (for new features)API changes documented in Release Notes