Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freq argument added to Model init. #315

Merged
merged 3 commits into from
Sep 2, 2021
Merged

freq argument added to Model init. #315

merged 3 commits into from
Sep 2, 2021

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Sep 2, 2021 •
edited

Short Description

Addressing and closing Issue #93.

Checklist before PR can be merged:

  • closes issue #xxxx
  • is documented
  • PEP8 compliant code
  • tests added / passed
  • API changes documented in Release Notes

@raoulcollenteur
Add frerq to model init #93
0b47e1d 
and remove Model._set_freq as it is not used anymore.
@raoulcollenteur
Update release_0.18.rst
3f1ecec
@raoulcollenteur raoulcollenteur mentioned this pull request Sep 2, 2021
Merged
6 tasks
@raoulcollenteur raoulcollenteur removed the request for review from OnnoEbbens September 2, 2021 15:35
@raoulcollenteur raoulcollenteur merged commit 0fad606 into dev Sep 2, 2021
@raoulcollenteur raoulcollenteur deleted the model_freq branch September 2, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrakenhoff dbrakenhoff dbrakenhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raoulcollenteur @dbrakenhoff