-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master to v0.19.0 #362
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial commit for the FlexSnowModel
changing numpy array while using numba jit does not work.
- make snow model optional in flexmodel - add experimental groundwater uptake / evaporation feature Will eventually be merge with the FlexModel :)
- Set parameter kv to vary=True by default (#318) - Make interception bucket optional (#314)
fix issue #320
get_response add_0=True correct index
Kraijenhoff van de Leur Response Function. Without numba this response function takes forever. The parameter n should in theory be infinity but in practice >100 seems fine. The numba error which is obtained is: TypingError: non-precise type pyobject I tried converting every np.array in def(step) into dtype=np.float64 but that does not seem to work.
thank you @dbrakenhoff :)
in python 3.9
big thanks to @dbrakenhoff
Fix #353, precision of floats in JSON files
- add option to add list of tmin/tmax for different models - rescale axes if adjust_height is set to False (ensures all plotted data is visible) - otherwise keep axes aspect-ratios based on model with most stressmodels, some data may not be visible - set xlim to max-tmax, and min-tmin
Save and read options of FlexModel to/from pas-file
- automate setting year in the footer.
- introduce modelplots.py to hold Plots connect to Model class - use plots.py for all other plots - Improve API documentation for plotting methods
dbrakenhoff
reviewed
Dec 30, 2021
improve docstring for get_equidistant_timeseries
dbrakenhoff
reviewed
Jan 3, 2022
def __init__(self, stress, rfunc1, rfunc2, name, tchange, up=True, | ||
cutoff=0.999, settings=None, metadata=None): | ||
if isinstance(stress, list): | ||
stress = stress[0] # TODO Temporary fix Raoul, 2017-10-24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An old todo?
dbrakenhoff
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Update the master-branch to v0.19.0.