Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master to v0.19.0 #362

Merged
merged 133 commits into from
Jan 4, 2022
Merged

Update master to v0.19.0 #362

merged 133 commits into from
Jan 4, 2022

Conversation

raoulcollenteur
Copy link
Member

Short Description

Update the master-branch to v0.19.0.

raoulcollenteur and others added 30 commits February 25, 2021 15:33
Initial commit for the FlexSnowModel
changing numpy array while using numba jit does not work.
- make snow model optional in flexmodel
- add experimental groundwater uptake / evaporation feature

Will eventually be merge with the FlexModel :)
I forgot an np.abs
improve atol calculation for bounds check for case pmin=0.0
improve atol calculation for bounds check for case pmin=np.nan
- Set parameter kv to vary=True by default (#318)
- Make interception bucket optional (#314)
get_response add_0=True correct index
Kraijenhoff van de Leur Response Function. Without numba this response function takes forever. The parameter n should in theory be infinity but in practice >100 seems fine.

The numba error which is obtained is: TypingError: non-precise type pyobject
I tried converting every np.array in def(step) into dtype=np.float64 but that does not seem to work.
dbrakenhoff and others added 12 commits December 7, 2021 15:58
Fix #353, precision of floats in JSON files
- add option to add list of tmin/tmax for different models
- rescale axes if adjust_height is set to False (ensures all plotted data is visible)
- otherwise keep axes aspect-ratios based on model with most stressmodels, some data may not be visible
- set xlim to max-tmax, and min-tmin
Save and read options of FlexModel to/from pas-file
- automate setting year in the footer.
- introduce modelplots.py to hold Plots connect to Model class
- use plots.py for all other plots
- Improve API documentation for plotting methods
@raoulcollenteur raoulcollenteur marked this pull request as ready for review December 30, 2021 13:02
@raoulcollenteur raoulcollenteur removed the request for review from rubencalje December 31, 2021 09:47
def __init__(self, stress, rfunc1, rfunc2, name, tchange, up=True,
cutoff=0.999, settings=None, metadata=None):
if isinstance(stress, list):
stress = stress[0] # TODO Temporary fix Raoul, 2017-10-24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An old todo?

Copy link
Member

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@raoulcollenteur raoulcollenteur merged commit efacd4e into master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants