-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Groundwater Signatures Module #372
Conversation
Obtain all signatures with a single method.
Adressing Issue #370
Cool addition :) General question: How applicable are all the tests for different frequencies of time series? Both for time series with a large frequency (e.g. monthly) or time series with differing frequency (14D -> 1D). Anything the user should be aware of beforehand? |
Thanks. This is generally up to the user, although some signatures are defined for a certain frequency (for example, they use the annual or monthly mean). Heudorfer et al (2019) has a good overview table for the recommended frequencies, but I think this is still up for debate in the future. I accidentally directed the merge PR into master, but changed it to the Dev-branch now. @martinvonk, can you re-review and approve if appropriate? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Short Description
Introducing the groundwater signatures module to characterise groundwater time series. For more information see Issue #370. The PR includes over 30 signatures that are currently implemented, documented, and tested for minimal functioning.
Checklist before PR can be merged: