Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Groundwater Signatures Module #372

Merged
merged 11 commits into from
Mar 8, 2022
Merged

Add Groundwater Signatures Module #372

merged 11 commits into from
Mar 8, 2022

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Mar 3, 2022

Short Description

Introducing the groundwater signatures module to characterise groundwater time series. For more information see Issue #370. The PR includes over 30 signatures that are currently implemented, documented, and tested for minimal functioning.

Checklist before PR can be merged:

@raoulcollenteur raoulcollenteur self-assigned this Mar 3, 2022
@raoulcollenteur raoulcollenteur added the development Indicates development of new features label Mar 3, 2022
@raoulcollenteur raoulcollenteur added this to the 0.20.0 milestone Mar 3, 2022
pastas/stats/tests.py Outdated Show resolved Hide resolved
pastas/stats/signatures.py Outdated Show resolved Hide resolved
pastas/stats/signatures.py Show resolved Hide resolved
@martinvonk
Copy link
Collaborator

Cool addition :)

General question: How applicable are all the tests for different frequencies of time series? Both for time series with a large frequency (e.g. monthly) or time series with differing frequency (14D -> 1D). Anything the user should be aware of beforehand?

@raoulcollenteur raoulcollenteur changed the base branch from master to dev March 7, 2022 06:22
@raoulcollenteur
Copy link
Member Author

Cool addition :)

General question: How applicable are all the tests for different frequencies of time series? Both for time series with a large frequency (e.g. monthly) or time series with differing frequency (14D -> 1D). Anything the user should be aware of beforehand?

Thanks. This is generally up to the user, although some signatures are defined for a certain frequency (for example, they use the annual or monthly mean). Heudorfer et al (2019) has a good overview table for the recommended frequencies, but I think this is still up for debate in the future.

I accidentally directed the merge PR into master, but changed it to the Dev-branch now. @martinvonk, can you re-review and approve if appropriate?
Cheers, Raoul

Copy link
Collaborator

@martinvonk martinvonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@raoulcollenteur raoulcollenteur merged commit 46ea4bd into dev Mar 8, 2022
@dbrakenhoff dbrakenhoff deleted the signatures branch January 10, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Indicates development of new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Development] Groundwater Signatures in Pastas
2 participants