454 Add .gitattribute file for linguist settings #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore .pas file since they are recognized as Pascal language
ignore test folder instead of .pas files
linguist settings based which controls the GitHub language ignore .pas files count Jupyter Notebooks as Python files
raoulcollenteur
approved these changes
Jan 10, 2023
|
Looks ready right? Squash and merge if yes! |
|
Yes, maybe @dbrakenhoff can have a quick look and judge whether moving the .gitattributes file to the .github folder will work? |
|
I think it has to be the root: https://git-scm.com/book/en/v2/Customizing-Git-Git-Attributes |
dbrakenhoff
requested changes
Jan 10, 2023
move to root folder linguist settings based which controls the GitHub language - ignore .pas files - count Jupyter Notebooks as Python files
dbrakenhoff
approved these changes
Jan 10, 2023
martinvonk
added
the
code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
This will hopefully show the correct programming language on GitHub which is essential for searching capabilities on GitHub. I try to get away with moving the .gitattribute file to the .github folder. Hopefully that works, we can only find out after merging 馃檭.
I now do two things:
Checklist before PR can be merged: