Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add impulse response functions to all rfunc #472

Merged
merged 36 commits into from Jan 19, 2023
Merged

Add impulse response functions to all rfunc #472

merged 36 commits into from Jan 19, 2023

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Jan 19, 2023 •
edited

Short Description

  • Add impulse response functions to all rfunc
  • Update init signatures
  • Couple of small changes to docs

EDIT: ready for review.

Checklist before PR can be merged:

martinvonk and others added 14 commits January 11, 2023 12:50
@martinvonk
add latexify.function decorator
95ceee4
@martinvonk
add type hinting to decorators.py
1b4998a
@martinvonk
add latexify to impulse response functions in rfunc
c73602a
@mbakker7
updated notebook
cfcffc2
@martinvonk
add use_raw_function_name arg to latexfun decorator
e89824a 
useful for function names with underscore _ such as polder_function
@mbakker7
added impulse response for DoubleExponential and FourParam
d43d44a 
Edelman still not finished
@mbakker7
fixed Polder impulse response
80341a3
@martinvonk
implement kraijenhoff van de leur impulse response first try
d7087a3 
fix pi problem
implement kraijenhoff vd leur impulse response (does not fully work yet)
@martinvonk
Merge branch 'dev' into 453-impulse-rfunc
fd39319
@martinvonk
Update decorators.py
9ecfa9c 
formatting related
@martinvonk
add impulse for kraijenhoff
a5224f7 
based on bruggeman equation 133.15
@martinvonk
add latexify as optional dependency
822ed8f
@raoulcollenteur
Change init signatures and attribute setting
9f7c830 
This is how it should have been implemented I think.
@martinvonk
Merge branch '453-impulse-rfunc' of https://github.com/pastas/pastas …
379475f 
…into 453-impulse-rfunc
@raoulcollenteur raoulcollenteur added this to the 0.23.0 milestone Jan 19, 2023
@raoulcollenteur raoulcollenteur marked this pull request as draft January 19, 2023 08:23
raoulcollenteur and others added 10 commits January 19, 2023 09:48
@raoulcollenteur
rename _set_init_parameter_settings to update_rfunc_settings
1b36f11 
Method had nothing to do with parameters, I think new name is better. Internal method, so changing can be done without issues.
@raoulcollenteur
Update all docstrings in rfunc.py
943d172
@raoulcollenteur
remove unnecessary pass statements
07c7bbd
@mbakker7
fixed Kraijenhoff impulse
dc84b78
@mbakker7
Merge branch '453-impulse-rfunc' of https://github.com/pastas/pastas …
8e1956d 
…into 453-impulse-rfunc
@raoulcollenteur
black format stressmodels.py
72b25cc
@mbakker7
final fix Kraijenhoff impulse
6d12a3e 
Sum now looks nice latexified.
@martinvonk needs to remove some of the Kraijenhoff derivation
@mbakker7
Merge branch '453-impulse-rfunc' of https://github.com/pastas/pastas …
9cdc41d 
…into 453-impulse-rfunc
@martinvonk
Update rfunc.py
53af26a 
remove old impulse_kraijenhoff
add nterms as keyword argument to kraijenhoff impulse
@martinvonk
Update check_response_functions.ipynb
047738d 
update documentation on kraijenhoff
@martinvonk martinvonk marked this pull request as ready for review January 19, 2023 11:07
@martinvonk
Update rfunc.py
eab10c9 
remove nterms as keyword argument
fix impulse fourparam since A is not used but called
@martinvonk
Update check_response_functions.ipynb
17af48a 
call plt.show() such that readthedocs shows figures. figures are not shown in readthedocs otherwise because black formatting does not accept a semicolumn.
@raoulcollenteur
Copy link
Member Author

@dbrakenhoff this PR is ready for review.

@martinvonk
Update rfunc.py
9759061 
remove unnecessary latexify identifier
dbrakenhoff
dbrakenhoff reviewed Jan 19, 2023
View reviewed changes
pastas/decorators.py Outdated Show resolved Hide resolved
dbrakenhoff
dbrakenhoff reviewed Jan 19, 2023
View reviewed changes
pastas/rfunc.py Outdated Show resolved Hide resolved
dbrakenhoff
dbrakenhoff approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@martinvonk
fix @dbrakenhoff comments
1ef5c59 
-remove Decorator type since it is essentialy a function
- fix weird indent in docstring
- fix response_functions notebook
@martinvonk martinvonk merged commit d1f56bf into dev Jan 19, 2023
@martinvonk martinvonk deleted the 453-impulse-rfunc branch January 20, 2023 11:05
@raoulcollenteur raoulcollenteur mentioned this pull request Jan 30, 2023
Closed
@martinvonk martinvonk added enhancement Indicates improvement of existing features documentation Indicates a need for improvements or additions to documentation labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinvonk martinvonk martinvonk left review comments

@dbrakenhoff dbrakenhoff dbrakenhoff approved these changes

Assignees

@mbakker7 mbakker7

Labels
documentation Indicates a need for improvements or additions to documentation enhancement Indicates improvement of existing features
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raoulcollenteur @dbrakenhoff @martinvonk @mbakker7