Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix release v0.23.1 #517

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Bugfix release v0.23.1 #517

merged 3 commits into from
Feb 2, 2023

Conversation

dbrakenhoff
Copy link
Member

@dbrakenhoff dbrakenhoff commented Feb 1, 2023

Short Description

Branch for bugfixes for v0.23

Bug fixes:

  • add logic for settings as dict for WellModel
  • ...

Checklist before PR can be merged:

- add logic for settings as dict
@codacy-production
Copy link

Coverage summary from Codacy

Merging #517 (e1ec745) into master (b7c66ba) - See PR on Codacy

Coverage variation Diff coverage
+6.61% (target: +0.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b7c66ba) 5312 3788 71.31%
Head commit (e1ec745) 5312 (+0) 4139 (+351) 77.92% (+6.61%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#517) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@raoulcollenteur
Copy link
Member

looks good. I updated the Pastas version and will merge this into Master and make a new release after. Thanks for the bug fix !

@raoulcollenteur raoulcollenteur merged commit 2bbc91e into master Feb 2, 2023
@raoulcollenteur raoulcollenteur deleted the 0-23-1_bugfix-release branch February 2, 2023 13:00
@raoulcollenteur raoulcollenteur added this to the 0.23.1 milestone Feb 2, 2023
@raoulcollenteur raoulcollenteur self-assigned this Feb 2, 2023
@raoulcollenteur raoulcollenteur added the bug Indicates an unintended behavior or coding error label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unintended behavior or coding error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants