Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types.py to support Matplotlib <v3.4 #553

Merged
merged 8 commits into from
Feb 20, 2023
Merged

Conversation

martinvonk
Copy link
Collaborator

Short Description

Matplotlib only has FigureBase since >v3.3 so this gives this would give an ImportError if the Matploblib version of the user was <=v3.3. If we want to keep supporting:

"matplotlib >= 3.1",

this small change has to be made.

Checklist before PR can be merged:

@martinvonk martinvonk self-assigned this Feb 15, 2023
@martinvonk martinvonk added the bug Indicates an unintended behavior or coding error label Feb 15, 2023
@martinvonk martinvonk marked this pull request as ready for review February 15, 2023 10:40
@martinvonk
Copy link
Collaborator Author

Not sure why the tests fail. Locally things seem fine.

@dbrakenhoff
Copy link
Member

dbrakenhoff commented Feb 15, 2023

I think a new version of matplotlib or pandas is causing an issue between the two. Perhaps try updating to the CI versions locally and see if you can run example_uncertainty.py?

@martinvonk martinvonk linked an issue Feb 20, 2023 that may be closed by this pull request
@martinvonk martinvonk requested review from dbrakenhoff and removed request for raoulcollenteur February 20, 2023 10:34
@martinvonk martinvonk added this to the 1.1 milestone Feb 20, 2023
@codacy-production
Copy link

codacy-production bot commented Feb 20, 2023

Coverage summary from Codacy

Merging #553 (96de513) into dev (a37e95c) - See PR on Codacy

Coverage variation Diff coverage
+0.41% (target: +0.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a37e95c) 4888 3493 71.46%
Head commit (96de513) 4888 (+0) 3513 (+20) 71.87% (+0.41%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#553) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@dbrakenhoff dbrakenhoff merged commit 29ef2f9 into dev Feb 20, 2023
@dbrakenhoff dbrakenhoff deleted the martinvonk-patch-1 branch February 20, 2023 13:28
@martinvonk martinvonk restored the martinvonk-patch-1 branch February 27, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unintended behavior or coding error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Development] Static type checking and PEP 561 compliance
2 participants