-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update types.py to support Matplotlib <v3.4 #553
Conversation
remove whitespace
Not sure why the tests fail. Locally things seem fine. |
I think a new version of matplotlib or pandas is causing an issue between the two. Perhaps try updating to the CI versions locally and see if you can run example_uncertainty.py? |
Coverage summary from CodacyMerging #553 (96de513) into
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
fix overwrite import
…into martinvonk-patch-1
Short Description
Matplotlib only has
FigureBase
since >v3.3 so this gives this would give anImportError
if the Matploblib version of the user was <=v3.3. If we want to keep supporting:pastas/pyproject.toml
Line 25 in 7302511
this small change has to be made.
Checklist before PR can be merged: