Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datetime axes with pandas.Timestamp and some other improvements #557

Merged
merged 6 commits into from
Feb 20, 2023

Conversation

dbrakenhoff
Copy link
Member

Short Description

  • fix tests
  • codacy issues in timer.py
  • isort
  • support lineartrends in CompareModels

Checklist before PR can be merged:

  • closes issue
  • is documented
  • Format code with Black formatting
  • type hints for functions and methods
  • tests added / passed
  • Example Notebook (for new features)
  • Remove output for all notebooks with changes

- temporary(?) fix for tmin/tmax
- ax.set_xlim("2010", "2015") not working with matplotlib 3.6.1 and pandas 1.5.3
@martinvonk martinvonk changed the title Fix tests and some other improvements Fix datetime axes with pandas.Timestamp and some other improvements Feb 17, 2023
@codacy-production
Copy link

codacy-production bot commented Feb 17, 2023

Coverage summary from Codacy

Merging #557 (10522d3) into dev (9a3d810) - See PR on Codacy

Coverage variation Diff coverage
-0.01% (target: +0.00%) 53.85%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9a3d810) 4869 3480 71.47%
Head commit (10522d3) 4888 (+19) 3493 (+13) 71.46% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#557) 26 14 53.85%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@martinvonk martinvonk added the bug Indicates an unintended behavior or coding error label Feb 17, 2023
@dbrakenhoff dbrakenhoff merged commit a37e95c into dev Feb 20, 2023
@dbrakenhoff dbrakenhoff deleted the some-improvements branch February 20, 2023 10:13
martinvonk added a commit that referenced this pull request Feb 20, 2023
commit a37e95c
Merge: 9a3d810 10522d3
Author: Davíd Brakenhoff <d.brakenhoff@artesia-water.nl>
Date:   Mon Feb 20 11:13:50 2023 +0100

    Fix datetime axes with pandas.Timestamp and some other improvements (#557)

commit 10522d3
Author: dbrakenhoff <d.brakenhoff@artesia-water.nl>
Date:   Fri Feb 17 14:26:33 2023 +0100

    add tmin/tmax fix to ps.plots.series()
    revert nb change

commit 51f8282
Author: Martin Vonk <vonk.mart@gmail.com>
Date:   Fri Feb 17 13:24:53 2023 +0100

    fix notebooks pd Timestamp errors

commit 4cc49df
Author: dbrakenhoff <d.brakenhoff@artesia-water.nl>
Date:   Fri Feb 17 12:14:42 2023 +0100

    isort

commit 25eeb8b
Author: dbrakenhoff <d.brakenhoff@artesia-water.nl>
Date:   Fri Feb 17 12:14:28 2023 +0100

    codacy fixes for timer.py

commit 205faa9
Author: dbrakenhoff <d.brakenhoff@artesia-water.nl>
Date:   Fri Feb 17 12:13:57 2023 +0100

    support linear trends in modelcompare

commit 3eac98a
Author: dbrakenhoff <d.brakenhoff@artesia-water.nl>
Date:   Fri Feb 17 12:13:28 2023 +0100

    fix tests
    - temporary(?) fix for tmin/tmax
    - ax.set_xlim("2010", "2015") not working with matplotlib 3.6.1 and pandas 1.5.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unintended behavior or coding error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants