Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #564 #565

Merged
merged 1 commit into from Feb 23, 2023
Merged

Fix issue #564 #565

merged 1 commit into from Feb 23, 2023

Conversation

rubencalje
Copy link
Collaborator

@rubencalje rubencalje commented Feb 23, 2023

Short Description

This pull request fixes issue #564 by not saving the oseries variable in the TarsoModel anymore. This variable is only used to determine dmin and dmax, which are stored in TarsoModel. So there is no need to also keep a reference to oseries.

Checklist before PR can be merged:

@codacy-production
Copy link

Coverage summary from Codacy

Merging #565 (d0df646) into dev (cf48f09) - See PR on Codacy

Coverage variation Diff coverage
+0.01% (target: +0.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cf48f09) 4893 3513 71.80%
Head commit (d0df646) 4891 (-2) 3512 (-1) 71.81% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#565) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@rubencalje rubencalje merged commit ea6797e into dev Feb 23, 2023
@rubencalje rubencalje deleted the Fix-issue-#564 branch February 23, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants