Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codacy coverage upload, auto-assign pr and flake8 update #566

Merged
merged 4 commits into from
Mar 21, 2023

Conversation

martinvonk
Copy link
Collaborator

@martinvonk martinvonk commented Feb 27, 2023

Short Description

Sinced #515 the codacy coverage report is uploaded from the GitHub CI test that takes the longest. This was a temporary fix because the if statements in the ci.yml did not work properly. Also, it is not a very robust solution if we introduce a CI test that takes longer (e.g. readthedocs #458). With this change the codacy coverage report is specifically created in the notebooks toxenv in the GitHub CI Test suite for Jupyter Notebooks.

@martinvonk martinvonk self-assigned this Feb 27, 2023
@martinvonk martinvonk changed the title Create and upload codacy coverage report from notebooks toxenv Create and upload codacy coverage report properly Feb 27, 2023
@codacy-production
Copy link

codacy-production bot commented Feb 27, 2023

Coverage summary from Codacy

Merging #566 (7e97c3f) into dev (ea6797e) - See PR on Codacy

Coverage variation Diff coverage
+0.29% (target: +0.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ea6797e) 4891 3512 71.81%
Head commit (7e97c3f) 4871 (-20) 3512 (+0) 72.10% (+0.29%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#566) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@martinvonk martinvonk marked this pull request as ready for review February 27, 2023 13:48
@martinvonk martinvonk added the code quality Related to code quality, testing, CI, project setup etc. label Feb 27, 2023
@martinvonk
Copy link
Collaborator Author

Latest commit 7e97c3f auto assigns authors to pull requests which is kinda neat I think

@martinvonk martinvonk changed the title Create and upload codacy coverage report properly Codacy coverage upload, auto-assign pr and flake8 update Mar 21, 2023
@dbrakenhoff dbrakenhoff merged commit 072b6f0 into dev Mar 21, 2023
@dbrakenhoff dbrakenhoff deleted the martinvonk-patch-1 branch March 21, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Related to code quality, testing, CI, project setup etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants