-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MCMC solver to Pastas #572
Conversation
- Add objective_functions to docs - Raise error if bounds or stderr is none - add _set_dist to transform -
Add set_parameter method for the solver parameters, allowing also to fix one of the parameters of the objective function
Coverage summary from CodacyMerging #572 (9945c38) into
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this looks cool!
Besides the comments I made in the code a couple of comments here:
- Perhaps it would be interesting to compare the priors and posteriors for one or more parameters in the example notebook?
- Can we help the user a bit more selecting some default emcee parameters, if that is possible?
- Add emcee group to pyproject.toml with optional packages: [emcee, corner, tqdm]?
Thanks for the review! I made all the your suggested in the notebook and code. I think
I will note this one down for a future development :)
Not really to be honest, if people want to use this solver they should really read the emcee docs before. I removed some of the defaults in the docstrings, and in the notebook I just want to show how to use them. Then users can figure this out themselves for now. In later stage after we got some more experience with the solver ourselves we may be able to give more guidance..
Yes, Done! Let me know if all is good and if I may merge :) Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Short Description
In this PR a MCMC solver based on Emcee is added to Pastas. Here are the most important changes:
This does not add dependencies, but if one wants to use it emcee and corner should be installed.
Checklist before PR can be merged:
I think the current implementation works well, so curious to hear what you all think about it!
Cheers,
Raoul