fix #551: up and gain_scale_factor are set by StressModel
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- up and gain_scale_factor arguments removed from RfuncBase init - attributes have default values up=None and gain_scale_factor=1.0 - attributes are updated by StressModels using update_rfunc_settings() - expose method update_rfunc_settings for external use (e.g. for setting up and gain_scale_factor for synthetically generated time series).
- remove up and gain_scale_factor from dict and set using update_rfunc_settings - fix test the same way
Coverage summary from CodacyMerging #573 (51b148c) into
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
raoulcollenteur
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
As discussed:
uporgain_scale_factorin response function init, added trap to raise TypeError if they are passed to init.rfunc.update_rfunc_settings()rfunc.update_rfunc_settings()Once again a question in relation to deprecation warnings. I can modify the trap to generate a warning instead of raising an error if up is passed to the response function, do we want that, or since we never intended this behavior is it okay to just make the change? I vote for the latter option.
Commits
Checklist before PR can be merged: