Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #549 stderr formatting #580

Merged
merged 1 commit into from May 3, 2023
Merged

Conversation

dbrakenhoff
Copy link
Member

  • add na_rep to _table_formatter_stderr, default is blank (for tables in plots) but use "nan" for fit_report.
  • use stderr formatter in fit_report

Short Description

use existing stderr formatter in fit_report to avoid extremely large values being represented in normal notation.

Checklist before PR can be merged:

- add na_rep to _table_formatter_stderr
- use stderr formatter in fit_report
@dbrakenhoff dbrakenhoff added the enhancement Indicates improvement of existing features label Mar 23, 2023
@dbrakenhoff dbrakenhoff linked an issue Mar 23, 2023 that may be closed by this pull request
@codacy-production
Copy link

Coverage summary from Codacy

Merging #580 (19d2986) into dev (1379345) - See PR on Codacy

Coverage variation Diff coverage
+0.00% (target: +0.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1379345) 4910 3565 72.61%
Head commit (19d2986) 4910 (+0) 3565 (+0) 72.61% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#580) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@raoulcollenteur
Copy link
Member

Looks good, merging! Thanks for fixing this long standing issue :)

@raoulcollenteur raoulcollenteur merged commit 1ac2182 into dev May 3, 2023
9 checks passed
@raoulcollenteur raoulcollenteur deleted the 549-improve-formatting-of-stderr branch May 3, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Improve formatting of "stderr" throughout Pastas
2 participants