Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.11 #588

Merged
merged 8 commits into from
May 3, 2023
Merged

Support Python 3.11 #588

merged 8 commits into from
May 3, 2023

Conversation

martinvonk
Copy link
Collaborator

@martinvonk martinvonk commented May 2, 2023

Short Description

Since Numba supports Python 3.11 (numba >= 0.57) we can add support for Python v3.11 as well.

The optional dependency latexify-py does not support Python 3.11 yet (officially). I now install that from the GitHub page cause that should work but is not very robust. google/latexify_py#175

Checklist before PR can be merged:

latexify only supports python 3.11 on main branch but no official release yet: google/latexify_py#175
so numba >= 0.57 supports python v 3.11 but pip should be able to detect this on it's own. This was only for testing purposes for the release candiate
@codacy-production
Copy link

Coverage summary from Codacy

Merging #588 (37dd9e1) into dev (330a808) - See PR on Codacy

Coverage variation Diff coverage
+0.00% (target: +0.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (330a808) 4914 3569 72.63%
Head commit (37dd9e1) 4914 (+0) 3569 (+0) 72.63% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#588) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@raoulcollenteur raoulcollenteur merged commit 285a58f into dev May 3, 2023
9 checks passed
@raoulcollenteur raoulcollenteur deleted the py311 branch May 3, 2023 11:02
@martinvonk martinvonk added the code quality Related to code quality, testing, CI, project setup etc. label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Related to code quality, testing, CI, project setup etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants