Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

602 wellmodel fixes 2,3 #603

Merged
merged 4 commits into from
Jun 21, 2023
Merged

602 wellmodel fixes 2,3 #603

merged 4 commits into from
Jun 21, 2023

Conversation

dbrakenhoff
Copy link
Member

@dbrakenhoff dbrakenhoff commented Jun 6, 2023

Short Description

Add a short description describing the pull request (PR) here.

Checklist before PR can be merged:

  • closes issue Issues with WellModel [BUG] #602, items 2 and 3
  • is documented
  • Format code with Black formatting
  • type hints for functions and methods
  • tests added / passed
  • Example Notebook (for new features)
  • Remove output for all notebooks with changes

@dbrakenhoff dbrakenhoff changed the base branch from master to dev June 6, 2023 13:17
@codacy-production
Copy link

codacy-production bot commented Jun 6, 2023

Coverage summary from Codacy

Merging #603 (d97e461) into dev (f8b0771) - See PR on Codacy

Coverage variation Diff coverage
+0.00% (target: +0.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (f8b0771) 4955 3599 72.63%
Head commit (d97e461) 4955 (+0) 3599 (+0) 72.63% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#603) 4 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@raoulcollenteur raoulcollenteur merged commit cb06df7 into dev Jun 21, 2023
10 checks passed
@raoulcollenteur raoulcollenteur deleted the 602-wellmodel branch November 29, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants