Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 608 #615

Merged
merged 7 commits into from
Aug 17, 2023
Merged

Fix issue 608 #615

merged 7 commits into from
Aug 17, 2023

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Aug 11, 2023

Short Description

Start using MySt_NB and fix issue #608 with Pandas DataFrames not displaying well.

Checklist before PR can be merged:

@raoulcollenteur raoulcollenteur added this to the 1.2 milestone Aug 11, 2023
@raoulcollenteur raoulcollenteur added the documentation Indicates a need for improvements or additions to documentation label Aug 11, 2023
@codacy-production
Copy link

codacy-production bot commented Aug 11, 2023

Coverage summary from Codacy

Merging #615 (ad0bf37) into dev (6a1bc90) - See PR on Codacy

Coverage variation Diff coverage
-0.07% (target: +0.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6a1bc90) 4965 3599 72.49%
Head commit (ad0bf37) 5105 (+140) 3697 (+98) 72.42% (-0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#615) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@raoulcollenteur
Copy link
Member Author

Using MyST_nb fixes the pandas data frame issue #608: https://pastas--615.org.readthedocs.build/en/615/examples/basic_model.html

But introduced a new one, now the links that @martinvonk made on the examples index page don't work, but in the sidebar they do. @martinvonk can you fix that?

@raoulcollenteur raoulcollenteur changed the title Start using newest sphinx Fix issue 608 Aug 11, 2023
@martinvonk
Copy link
Collaborator

martinvonk commented Aug 11, 2023

Using MyST_nb fixes the pandas data frame issue #608: https://pastas--615.org.readthedocs.build/en/615/examples/basic_model.html

But introduced a new one, now the links that @martinvonk made on the examples index page don't work, but in the sidebar they do. @martinvonk can you fix that?

Links now standard refer to: https://blabla/file.html instead of https://blabla/file.ipynb. So apparently notebooks don't exist anymore, only html pages.

@raoulcollenteur
Copy link
Member Author

Using MyST_nb fixes the pandas data frame issue #608: https://pastas--615.org.readthedocs.build/en/615/examples/basic_model.html
But introduced a new one, now the links that @martinvonk made on the examples index page don't work, but in the sidebar they do. @martinvonk can you fix that?

Links now standard refer to: https://blabla/file.html instead of https://blabla/file.ipynb. So apparently notebooks don't exist anymore, only html pages.

Cool I fixed it. Merging.

@raoulcollenteur raoulcollenteur merged commit 4fb3de9 into dev Aug 17, 2023
9 of 10 checks passed
@raoulcollenteur raoulcollenteur deleted the sphinx_6 branch August 17, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Indicates a need for improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants