Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update groundwater signatures module #636

Merged
merged 30 commits into from
Feb 16, 2024
Merged

Update groundwater signatures module #636

merged 30 commits into from
Feb 16, 2024

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Sep 5, 2023

Short Description

This PR updates the groundwater signatures module, after cross-checking with methods from Haaf and Heudorfer and additional logical checks in interpreting the computed signatures. It also adds a few new signatures.

Checklist before PR can be merged:

Complete overhaul of the module:

- remove magnitude
- remove magnitude
- remove amplitude range

- add duration_curve_ratio
- add cv_date_max

- add documentation
- reformat methods
- added some private methods shared by many signatures.
@raoulcollenteur raoulcollenteur self-assigned this Sep 5, 2023
@raoulcollenteur raoulcollenteur marked this pull request as draft September 5, 2023 13:47
@raoulcollenteur raoulcollenteur added this to the 1.3 milestone Sep 5, 2023
@raoulcollenteur raoulcollenteur added bug Indicates an unintended behavior or coding error enhancement Indicates improvement of existing features development Indicates development of new features labels Sep 5, 2023
@raoulcollenteur raoulcollenteur modified the milestones: 1.3, 1.4 Nov 28, 2023
Copy link

codacy-production bot commented Dec 11, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.17% (target: +0.00%) 77.61%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bd511df) 5834 4359 74.72%
Head commit (d453175) 5991 (+157) 4466 (+107) 74.55% (-0.17%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#636) 268 208 77.61%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@raoulcollenteur raoulcollenteur marked this pull request as ready for review December 12, 2023 11:04
@raoulcollenteur raoulcollenteur mentioned this pull request Dec 13, 2023
6 tasks
Co-authored-by: Raoul Collenteur <raoulcollenteur@gmail.com>
pastas/stats/signatures.py Outdated Show resolved Hide resolved
pastas/stats/signatures.py Outdated Show resolved Hide resolved
Add a minimum length in days, to make the signatures independent of measurement frequency.
similar to the exponential response, are they related?!
As it is hardly applicable to groundwater and highly impacted by the time steps.
More pastas-like, but deal with uncertainty in estimation of constants (mostly for short segments).

plus some docs
@raoulcollenteur raoulcollenteur requested review from OnnoEbbens and removed request for martinvonk January 31, 2024 10:53
@raoulcollenteur
Copy link
Member Author

This one should be good to go now after many, many changes to the code and docs.

@raoulcollenteur raoulcollenteur removed the request for review from OnnoEbbens February 13, 2024 14:07
@raoulcollenteur raoulcollenteur dismissed OnnoEbbens’s stale review February 13, 2024 14:08

Requested changes were made.

@raoulcollenteur raoulcollenteur merged commit 5251c97 into dev Feb 16, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unintended behavior or coding error development Indicates development of new features enhancement Indicates improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants