-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update groundwater signatures module #636
Conversation
Complete overhaul of the module: - remove magnitude - remove magnitude - remove amplitude range - add duration_curve_ratio - add cv_date_max - add documentation - reformat methods - added some private methods shared by many signatures.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Co-authored-by: Raoul Collenteur <raoulcollenteur@gmail.com>
Add a minimum length in days, to make the signatures independent of measurement frequency.
similar to the exponential response, are they related?!
As it is hardly applicable to groundwater and highly impacted by the time steps.
More pastas-like, but deal with uncertainty in estimation of constants (mostly for short segments). plus some docs
This one should be good to go now after many, many changes to the code and docs. |
Requested changes were made.
Short Description
This PR updates the groundwater signatures module, after cross-checking with methods from Haaf and Heudorfer and additional logical checks in interpreting the computed signatures. It also adds a few new signatures.
Checklist before PR can be merged: