Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for Problem adding LinearTrend #675 #676

Merged
merged 4 commits into from Jan 4, 2024

Conversation

OnnoEbbens
Copy link
Member

Close issue 675 and change the behavior of _check_response_tmax in such a way that this check is only done for stressmodels with a response function. Stressmodels without a response function, such as 'LinearTrend', will not be checked.

@OnnoEbbens OnnoEbbens marked this pull request as draft January 3, 2024 15:06
Copy link

codacy-production bot commented Jan 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: +0.00%) 39.29%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0d7e816) 5853 4378 74.80%
Head commit (84ca7cc) 5857 (+4) 4382 (+4) 74.82% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#676) 28 11 39.29%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

OnnoEbbens and others added 2 commits January 3, 2024 16:19
- use isinstance checks instead of checks on name
@dbrakenhoff dbrakenhoff marked this pull request as ready for review January 4, 2024 09:54
@OnnoEbbens OnnoEbbens merged commit 9c76689 into dev Jan 4, 2024
12 of 13 checks passed
@OnnoEbbens OnnoEbbens deleted the 675-problem-adding-lineartrend branch January 4, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants