Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-publish.yml #692

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Update python-publish.yml #692

merged 2 commits into from
Feb 20, 2024

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented Feb 19, 2024

Short Description

Quick PR to fix the python-publish workflow, because Pastas was not automatically uploaded to Pypi with the latest release.

Copy link

codacy-production bot commented Feb 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.13% (target: +0.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (eabc767) 5975 4457 74.59%
Head commit (33d7471) 5999 (+24) 4483 (+26) 74.73% (+0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#692) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@martinvonk
Copy link
Collaborator

martinvonk commented Feb 20, 2024

I can't judge if this will work? Maybe @dbrakenhoff can? Can't we test it on the test-pypi?

I am surprised however that the python-publish.yml fails, since this worked fine for Metran yesterday..

Copy link
Member

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we can delete the other PYPI secrets (USERNAME and PASSWORD) if this works properly.

@dbrakenhoff dbrakenhoff merged commit b9ef48b into master Feb 20, 2024
14 checks passed
@dbrakenhoff dbrakenhoff deleted the raoulcollenteur-patch-1 branch February 20, 2024 09:46
@dbrakenhoff
Copy link
Member

@raoulcollenteur it might be easiest to manually upload pastas 1.4 to PYPI with your token, instead of trying to re-release 1.4 on Github to trigger the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants