-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add load_dataset method to pastas #693
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Simple and effective!
We can add a function to list the available datasets?
def list_datasets():
r = requests.get(GITHUB_URL)
return [file["name"] for file in r.json() if file["type"]=="dir"]
I think PR is finished now and ready for review and hopefully merging. We can start adding data to the test_dataset as well if we want. I added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Short Description
This PR adds a load_dataset method to pastas, allowing users to load predefined test datasets from the Pastas new dataset repo (https://github.com/pastas/pastas-data/tree/main). For now, only a limited number of datasets are available, but more can be added later.
Checklist before PR can be merged:
Usage
Simple, just type:
ps.load_dataset("collenteur_2021")