Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning Day.delta is deprecated #713

Merged
merged 1 commit into from Mar 29, 2024
Merged

Conversation

rubencalje
Copy link
Collaborator

@rubencalje rubencalje commented Mar 27, 2024

This PR fixes the following warning you get in Pandas version 2.2.1 when loading a model from file or pastastore:
FutureWarning: Day.delta is deprecated and will be removed in a future version. Use pd.Timedelta(obj) instead

Short Description

Add a short description describing the pull request (PR) here.

Checklist before PR can be merged:

  • closes issue #xxxx
  • is documented
  • Format code with Black formatting
  • type hints for functions and methods
  • tests added / passed
  • Example Notebook (for new features)
  • Remove output for all notebooks with changes

…a future version. Use pd.Timedelta(obj) instead
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.45% (target: +0.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (67392f3) 6087 4582 75.28%
Head commit (2288d99) 6126 (+39) 4639 (+57) 75.73% (+0.45%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#713) 20 20 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@raoulcollenteur raoulcollenteur added this to the 1.5 milestone Mar 29, 2024
@raoulcollenteur raoulcollenteur added bug Indicates an unintended behavior or coding error enhancement Indicates improvement of existing features labels Mar 29, 2024
@rubencalje rubencalje merged commit c7b2b58 into dev Mar 29, 2024
13 checks passed
@rubencalje rubencalje deleted the fix_offset.delta_is_deprecated branch March 29, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unintended behavior or coding error enhancement Indicates improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants