Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry metadata in pas files #718

Merged
merged 2 commits into from Apr 9, 2024
Merged

Conversation

dbrakenhoff
Copy link
Member

@dbrakenhoff dbrakenhoff commented Apr 3, 2024

Short Description

Not sure if this is something we want to support, but the change is minimal, and convenient if your metadata contains geometric objects. Also useful for pastastore :).

Checklist before PR can be merged:

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: +0.00%) 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (812c42b) 6114 4627 75.68%
Head commit (eaf3e54) 6134 (+20) 4639 (+12) 75.63% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#718) 9 6 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@raoulcollenteur raoulcollenteur merged commit bf64e28 into dev Apr 9, 2024
11 of 13 checks passed
@raoulcollenteur raoulcollenteur deleted the geometry_metadata_in_pas_files branch April 9, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants