Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #738 #740

Merged
merged 6 commits into from Apr 15, 2024
Merged

Fix #738 #740

merged 6 commits into from Apr 15, 2024

Conversation

dbrakenhoff
Copy link
Member

Short Description

Fix issue with get_equidistant_series_nearest as shown in #738.

Additionally update some freq strings in dutch statistics and signatures. Can these be updated to new pandas versions?

Checklist before PR can be merged:

- improve getting new index for nearest resampling (based on most frequent offset relative to user-provided freq)
- sort concat calls
- add test based on nb example
@raoulcollenteur
Copy link
Member

Hi @dbrakenhoff, can you remove the freq-string changes? These only work for pandas => 2.2 (i.e. only the latest version) and I think we want to wait until the next release with that..

@dbrakenhoff
Copy link
Member Author

Hi @dbrakenhoff, can you remove the freq-string changes? These only work for pandas => 2.2 (i.e. only the latest version) and I think we want to wait until the next release with that..

my bad, wasn't sure what the status of that was :)

Copy link

codacy-production bot commented Apr 15, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.78% (target: +0.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8ec2944) 6230 4691 75.30%
Head commit (4208a1a) 6271 (+41) 4771 (+80) 76.08% (+0.78%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#740) 31 31 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@raoulcollenteur raoulcollenteur added this to the 1.5 milestone Apr 15, 2024
@raoulcollenteur raoulcollenteur added bug Indicates an unintended behavior or coding error enhancement Indicates improvement of existing features labels Apr 15, 2024
@raoulcollenteur raoulcollenteur merged commit daa0d31 into dev Apr 15, 2024
12 checks passed
@raoulcollenteur raoulcollenteur deleted the ts_utils branch April 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unintended behavior or coding error enhancement Indicates improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants