Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise exception if no samples are found within max_iter #757

Conversation

martinvonk
Copy link
Collaborator

Short Description

Raise exception if samples is empty

Checklist before PR can be merged:

pastas/solver.py Outdated Show resolved Hide resolved
pastas/solver.py Outdated Show resolved Hide resolved
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: +0.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ab06d0e) 6254 4737 75.74%
Head commit (590c3bd) 6297 (+43) 4769 (+32) 75.73% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#757) 4 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link

codacy-production bot commented May 15, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: +0.00%) 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ab06d0e) 6254 4737 75.74%
Head commit (239c94b) 6300 (+46) 4773 (+36) 75.76% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#757) 4 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@martinvonk martinvonk merged commit 521c239 into dev May 15, 2024
8 of 9 checks passed
@martinvonk martinvonk added the bug Indicates an unintended behavior or coding error label May 15, 2024
@raoulcollenteur raoulcollenteur deleted the 755-uninformative-error-message-if-samples-is-empty-and-max_iter-is-exceeded-in-get_parameter_sample branch June 11, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unintended behavior or coding error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uninformative error (message) if samples is empty and max_iter is exceeded in get_parameter_sample
2 participants