-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Ruff as linter and formatter and introduce git pre-commit hook #759
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
xrange = rfunc_plot.x_range | ||
else: | ||
xrange = False | ||
# xrange = False if rfunc_plot is None else rfunc_plot.x_range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be uncommented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xrange is an unused variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question but otherwise looks fine to me.
Short Description
Changes:
ruff check --extend-select I --fix
and format code with:ruff format
or do both in one command withtox -e ruff_fix
ruff check --extend-select I --preview
+ruff format --check
.pip install pre-commit
pre-commit install
Which checks if the code is formatted as per step 1.
Checklist before PR can be merged: