Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SGI applicable to DataFrame and add Dropna #760

Merged

Conversation

raoulcollenteur
Copy link
Member

@raoulcollenteur raoulcollenteur commented May 31, 2024

Short Description

Fix issue #742 and add option to use DataFrames as input.

Checklist before PR can be merged:

@raoulcollenteur raoulcollenteur self-assigned this May 31, 2024
@raoulcollenteur raoulcollenteur added bug Indicates an unintended behavior or coding error enhancement Indicates improvement of existing features labels May 31, 2024
@raoulcollenteur raoulcollenteur added this to the 1.6 milestone May 31, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% (target: +0.00%) 8.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (20d03d0) 6282 4761 75.79%
Head commit (31febec) 6325 (+43) 4798 (+37) 75.86% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#760) 12 1 8.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@raoulcollenteur raoulcollenteur merged commit ff1199b into dev May 31, 2024
12 of 13 checks passed
@raoulcollenteur raoulcollenteur deleted the 742-sgi-reports-wrong-values-if-nan-values-are-present branch May 31, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unintended behavior or coding error enhancement Indicates improvement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants