Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Webpack to version 5 #53

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Upgrade Webpack to version 5 #53

wants to merge 2 commits into from

Conversation

ardalanamini
Copy link

This is an attempt to upgrade to webpack version 5.

It seems to be generally working so far 馃
But still needs to make sure the config works for everything it was already working.

@ardalanamini
Copy link
Author

ardalanamini commented Sep 1, 2022 •
edited

Also, webpack already supports the package exports & imports (imports from "#*"), so the #* dependencies are not considered missing anymore (At least it seems to work for my tested package)

@ardalanamini ardalanamini marked this pull request as ready for review September 2, 2022 09:40
@ardalanamini
Copy link
Author

ardalanamini commented Sep 2, 2022 •
edited

Note: For normal packages, I tested it with: lodash-es@4.17.21, react-dom@18.2.0; It also worked for this package which is failing at bundlephobia right now (Terser related): prototyped.js@3.0.5

@ardalanamini ardalanamini mentioned this pull request Sep 2, 2022
Open
@jmetev1
Copy link

jmetev1 commented May 15, 2023

@pastelsky did you see this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ardalanamini @jmetev1