Improved query while expecting tag_names
#14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
9 Test cases were getting failed BEFORE as well as after my change. I have not fixed any existing failure of test cases 1 deprecation warning total
Finished in 0.41153 seconds
31 examples, 9 failures |
pat
added a commit
that referenced
this pull request
Jan 24, 2015
Improved query while expecting `tag_names`
|
Thanks! Seems the failing tests are due to Rails 4.2... haven't yet figured out a fix for that, but your patch is a great simple improvement - and thankfully pluck exists in Rails 3.2 as well (the earliest version of Rails this gem supports). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.